Conversation
Implemented changes in the UI withthe fetched data from API
Implemented stylings
Implemented integration testing
Implemented final touches
brytebee
left a comment
There was a problem hiding this comment.
Hi, @vangelif π,
Highlightsπ‘
- Good commit message.βοΈ
- Good PR Summary.βοΈ
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request π΄π΄
You have submitted a project, that has used the wrong flow and missed the linter files.
You should fix the linters.
You seem to have mixed up the flow that is supposed to be used.
NOTE
For group capstone projects the correct flow for requesting reviews is Github flow which means dev merging to main.
For solo capstone projects, the flow for requesting reviews is Gitflow which means feature branch merging to dev.
In this case, you clearly followed the wrong flow.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready π
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Implemented final deployment
β Deploy Preview for precious-crumble-870230 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |

In this project, I: